Add vdiff subcommands #113
Conversation
src/server/cli/vdiff/migrate.js
Outdated
| export async function migrate(argv = []) { | ||
| const { pattern = './**' } = commandLineArgs({ name: 'pattern', type: String, defaultOption: true }, { partial: true, argv }); |
There was a problem hiding this comment.
Only changes to this from the bin version were wrapping it in a function and changing the default pattern from ./test/** to ./** because there's no reason to restrict where to look for goldens by default.
There was a problem hiding this comment.
Will this look in node_modules? I remember that coming up in the old library
There was a problem hiding this comment.
It will, but it's being ignored on line 12
bearfriend
force-pushed
the
dgleckler/subcommands
branch
from
63681da
to
436634c
Compare
| @@ -15,8 +15,7 @@ | |||
| }, | |||
| "bin": { | |||
| "d2l-test-runner": "./bin/d2l-test-runner.js", | |||
| "d2l-test-vdiff-report": "./bin/d2l-test-vdiff-report.js", | |||
| "migrate-goldens": "./bin/migrate-goldens.js" | |||
| "dtr": "./bin/d2l-test-runner.js" | |||
There was a problem hiding this comment.
Lol not sure I'll be able to use this without reading it as "define the relationship"
| import { runner } from '../../src/server/cli/test-runner.js'; | ||
|
|
||
| const { argv, stdout } = process; |
There was a problem hiding this comment.
Importing process and destructuring allows us to modify argv globally to test different inputs.
|
🎉 This PR is included in version 0.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
migrate-goldenstod2l-test-runner vdiff migrated2l-test-vdiff-reporttod2l-test-runner vdiff report--goldenoption to a subcommandd2l-test-runner vdiff golden--helpoutputdtrshortcut command